GitHub Flow

1
2
3
4
5
6

[main branch] 
      |
[feature branch] --> [Pull Request] --> [Code Review] --> [CI/CD] --> [Merge to main] --> [Deploy]
      |                    |                |                |
      |                    |                |                |
[Local commits] <->[Discussion] <->[Tests] <->[Build]

1
2
3
4
5
6

# 새 저장소 생성 또는 기존 저장소 클론
git clone https://github.com/username/repository.git
cd repository

# main 브랜치 확인
git branch

1
2
3

git checkout main
git pull origin main
git checkout -b feature/123-add-login

1
2

git add .
git commit -m "로그인 기능 추가: #123"

1

git push origin feature/123-add-login

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25

[개발자 로컬] --> [Feature Branch] --> [Push to Remote]
                                           |
                                           v
                                    [Pull Request]
                                           |
                                           v
                                    [Code Review]
                                     /     |     \
                                    /      |      \
                            [Unit Tests] [Lint] [Build]
                                    \      |      /
                                     \     |     /
                                    [Approval Process]
                                           |
                                           v
                                    [Merge to Main]
                                           |
                                           v
                                [Automated Deployment]
                                     /          \
                                    /            \
                        [Staging Deploy]   [Production Deploy]
                                |                  |
                                v                  v
                        [E2E Tests]        [Monitoring]

1
2
3

# 최신 main 브랜치로 업데이트
git checkout main
git pull origin main

1
2
3
4
5
6
7

# 기능 브랜치 생성 및 체크아웃
git checkout -b feature/user-authentication

# 작업 진행
# - src/auth/login.js 생성
# - src/auth/register.js 생성
# - tests/auth.test.js 생성

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11

# 변경사항 커밋
git add .
git commit -m "feat: implement user authentication with JWT

- Add login endpoint with email/password validation
- Add registration with password hashing
- Add JWT token generation and validation
- Add unit tests for auth service"

# 원격 저장소로 푸시
git push -u origin feature/user-authentication

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23

## 🔐 User Authentication Feature

### Description
Implements user authentication system using JWT tokens.

### Changes
- Added login and registration endpoints
- Implemented JWT token generation/validation
- Added password hashing with bcrypt
- Created auth middleware for protected routes

### Testing
- ✅ Unit tests for auth service
- ✅ Integration tests for API endpoints
- ✅ Manual testing with Postman

### Checklist
- [x] Code follows style guidelines
- [x] Tests pass
- [x] Documentation updated
- [x] No security vulnerabilities

Closes #123

1
2

Line 45 in auth.service.js:
Consider using constant-time comparison for password validation to prevent timing attacks.

1

Good catch! Updated to use crypto.timingSafeEqual() for password comparison.

1
2

auth.middleware.js:
Should we add rate limiting to prevent brute force attacks?

1

Added express-rate-limit middleware with 5 attempts per 15 minutes for login endpoint.

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

name: CI

on:
  pull_request:
    branches: [ main ]

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Use Node.js
      uses: actions/setup-node@v2
      with:
        node-version: '18.x'
    
    - name: Install dependencies
      run: npm ci
    
    - name: Run linting
      run: npm run lint
    
    - name: Run tests
      run: npm test
    
    - name: Build project
      run: npm run build

1
2
3

✅ Linting - Passed
✅ Unit Tests - 42 passed
✅ Build - Success

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13

# GitHub에서 "Squash and merge" 버튼 클릭
# 또는 CLI에서:
git checkout main
git merge --squash feature/user-authentication
git commit -m "feat: implement user authentication system (#124)

* Add JWT-based authentication
* Implement login and registration endpoints
* Add password hashing and validation
* Include comprehensive test coverage

Co-authored-by: Reviewer1 <reviewer1@example.com>
Co-authored-by: Reviewer2 <reviewer2@example.com>"

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31

name: Deploy

on:
  push:
    branches: [ main ]

jobs:
  deploy-staging:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Deploy to Staging
      run: |
        npm run build
        npm run deploy:staging
    
    - name: Run E2E Tests
      run: npm run test:e2e
    
  deploy-production:
    needs: deploy-staging
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Deploy to Production
      run: |
        npm run build
        npm run deploy:production
    
    - name: Health Check
      run: npm run health-check:production

1
2
3
4
5
6
7
8
9

# 배포 스크립트 실행
npm run deploy:staging

# 출력
🚀 Deploying to staging environment...
📦 Building application...
📤 Uploading artifacts...
✅ Deployment successful!
🌍 Staging URL: https://staging.myapp.com

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17

describe('Authentication Flow', () => {
  it('should allow user registration', () => {
    cy.visit('/register')
    cy.get('input[name="email"]').type('test@example.com')
    cy.get('input[name="password"]').type('securePassword123')
    cy.get('button[type="submit"]').click()
    cy.url().should('include', '/dashboard')
  })

  it('should allow user login', () => {
    cy.visit('/login')
    cy.get('input[name="email"]').type('test@example.com')
    cy.get('input[name="password"]').type('securePassword123')
    cy.get('button[type="submit"]').click()
    cy.getCookie('token').should('exist')
  })
})

1
2
3
4
5
6
7
8
9

# 프로덕션 배포
npm run deploy:production

# 출력
🚀 Deploying to production environment...
📦 Building optimized bundle...
📤 Uploading to production servers...
✅ Deployment successful!
🌍 Production URL: https://myapp.com

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30

// 모니터링 설정
const alerts = {
  authenticationErrors: {
    threshold: 10,  // 10개 이상의 인증 실패
    timeWindow: '5m',  // 5분 이내
    severity: 'high',
    notify: ['security-team@company.com']
  },
  
  loginLatency: {
    threshold: 1000,  // 1초 이상의 응답 시간
    timeWindow: '1m',
    severity: 'medium',
    notify: ['devops-team@company.com']
  }
}

// Grafana 대시보드 설정
const dashboard = {
  panels: [
    {
      title: 'Authentication Success Rate',
      query: 'rate(auth_success_total[5m]) / rate(auth_attempts_total[5m])'
    },
    {
      title: 'JWT Token Generation Time',
      query: 'histogram_quantile(0.95, rate(jwt_generation_duration_seconds_bucket[5m]))'
    }
  ]
}

1
2
3
4
5
6

🔔 Alert: High authentication failure rate detected
- Current rate: 25 failures/minute
- Normal rate: 2-3 failures/minute
- Affected endpoint: /api/auth/login
- Time: 2024-01-20 15:30:22 UTC
- Action: Security team notified